Experiment: simpler light/dark toggle #18249
Merged
+1,371
−35,724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oh, and hey @uberbrady: 
|
Member
Author
|
This is coming along pretty nicely. I've got the buttons and the Task Menu working now. Screen.Recording.2025-11-26.at.3.54.38.PM.movI'd still like to see if I can't math my way into figuring out whether the text should be light or dark. (A white header color with dark mode would render that illegible. We could, of course, tell people not to do that, but... well... they will anyway.) |
Member
Author
|
Member
Author
|
I still also need to tweak some some of the borders on the detail view in dark mode - the lines are a little too sharply contrasted and distracting IMHO. |
Member
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a much more streamlined dark/light mode toggle and eliminates the "skins".
Screen.Recording.2025-12-02.at.2.20.04.PM.mov
New Admin Settings
Screen.Recording.2025-12-02.at.2.04.26.PM.mov
Override default link colors
Override default link colors - light mode
Override default link colors - dark mode
Users may also override the nav and link settings, though they will default back to whatever the Snipe-IT settings are if none are set at the user level.
Screen.Recording.2025-12-02.at.2.15.58.PM.mov
Right now I'm just using local storage, but I could easily save this to the users' profiles instead. I feel like the different contexts might bear different settings, and it's only one click to change it, so leaving it in local storage for now.
Some things I'm also playing with here: